[ML] Fix possible race condition starting datafeed #51646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datafeeds being closed while starting could result in and NPE. This was handled as any other failure, masking out the NPE. However, this conflicts with the changes in elastic#50886. Related to elastic#50886 and elastic#51302
|
Pinging @elastic/ml-core (:ml) |
henningandersen
commented
Jan 29, 2020
| @@ -520,7 +520,12 @@ private void runTask(TransportStartDatafeedAction.DatafeedTask task) { | |||
| // a context with sufficient permissions would coincidentally be in force in some single node | |||
| // tests, leading to bugs not caught in CI due to many tests running in single node test clusters. | |||
| try (ThreadContext.StoredContext ignore = threadPool.getThreadContext().stashContext()) { | |||
| innerRun(runningDatafeedsOnThisNode.get(task.getAllocationId()), task.getDatafeedStartTime(), task.getEndTime()); | |||
| Holder holder = runningDatafeedsOnThisNode.get(task.getAllocationId()); | |||
There was a problem hiding this comment.
Putting in a sleep(100) before this line provokes the NPE.
droberts195
approved these changes
Jan 29, 2020
| if (holder != null) { | ||
| innerRun(holder, task.getDatafeedStartTime(), task.getEndTime()); | ||
| } else { | ||
| logger.warn("Datafeed [{}] was closed while being opened", task.getDatafeedId()); |
There was a problem hiding this comment.
We use the terms “started” and “stopped” with datafeeds instead of “opened” and “closed”, so please could you change those two words in this message.
|
Thanks David. |
|
The test that failed in CI was |
henningandersen
added a commit
that referenced
this pull request
Jan 30, 2020
This was referenced Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datafeeds being closed while starting could result in and NPE. This was
handled as any other failure, masking out the NPE. However, this
conflicts with the changes in #50886.
Related to #50886 and #51302